Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: blog.golang.org still has a search bar #44912

Closed
marinthiercelin opened this issue Mar 10, 2021 · 2 comments
Closed

x/website: blog.golang.org still has a search bar #44912

marinthiercelin opened this issue Mar 10, 2021 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@marinthiercelin
Copy link

marinthiercelin commented Mar 10, 2021 •
edited

What version of Go are you using (go version)?

$ go version
go version go1.16 linux/amd64

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/marin/.cache/go-build"
GOENV="/home/marin/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/marin/Code/Go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/marin/Code/Go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build2049367862=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I went to https://blog.golang.org and typed a query in the search bar

What did you expect to see?

I expected to see results associated with the query

What did you see instead?

An error message saying the file doesn't exist.
Here's a screenshot of https://golang.org/search?q=go
image
This happens even with generic queries like 'go' (I would expect there to be quite a lot of articles related to that)
@gopherbot gopherbot added this to the Unreleased milestone Mar 10, 2021
@AlexRouSg
Copy link
Contributor

Search was intentionally removed in #44357
I guess they forgot about the blog.

cc @rsc

@ALTree ALTree added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 10, 2021
@prattmic prattmic changed the title x/website: search bar is unusable x/website: blog.golang.org still has a search bar Apr 19, 2021
@dmitshur dmitshur self-assigned this Apr 20, 2021
@gopherbot
Copy link

Change https://golang.org/cl/311969 mentions this issue: template: remove search box

gopherbot pushed a commit to golang/website that referenced this issue May 26, 2021
@dmitshur
[x/blog] template: remove search box
cd74f71 
The custom search algorithm that was previously implemented and served
on the golang.org website has been removed via CL 292590 and CL 293412,
so remove the search box in the blog.golang.org header too.

For golang/go#44357.
Fixes golang/go#44912.

Change-Id: I51478ccb568e94df50d0dc6920a26c8f30a04c3c
Reviewed-on: https://go-review.googlesource.com/c/blog/+/311969
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
X-Blog-Commit: 5d47918ba6b83a86f5752483a2310cda931dd255
@golang golang locked and limited conversation to collaborators Apr 20, 2022
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
[x/blog] template: remove search box
0cccb19 
The custom search algorithm that was previously implemented and served
on the golang.org website has been removed via CL 292590 and CL 293412,
so remove the search box in the blog.golang.org header too.

For golang/go#44357.
Fixes golang/go#44912.

Change-Id: I51478ccb568e94df50d0dc6920a26c8f30a04c3c
Reviewed-on: https://go-review.googlesource.com/c/blog/+/311969
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
X-Blog-Commit: 5d47918ba6b83a86f5752483a2310cda931dd255
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@dmitshur @ALTree @AlexRouSg @gopherbot @marinthiercelin