Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: import paths ending with '+' are rejected (affects executable like g++ or clang++) [1.16 backport] #44885

Closed
gopherbot opened this issue Mar 9, 2021 · 4 comments
Closed

cmd/go: import paths ending with '+' are rejected (affects executable like g++ or clang++) [1.16 backport] #44885

gopherbot opened this issue Mar 9, 2021 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.16.3

Comments

@gopherbot
Copy link

@bcmills requested issue #44776 to be considered for backport to the next 1.16 minor release.

@gopherbot, please backport to Go 1.16.

Go 1.16 added previously-missing path validation paths and enabled module mode by default, both of which made this check much more likely to be triggered.

I don't think this needs to be backported to Go 1.15. In 1.15, the go command had a bug that caused these paths not to be diagnosed if they are already present in some module in the build list. That bug was incidentally fixed in CL 258298 for Go 1.16. (This issue was exposed by the combination of fixing that bug and enabling module mode by default in Go 1.16.)
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 9, 2021
@gopherbot gopherbot mentioned this issue Mar 9, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.1 milestone Mar 9, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/300152 mentions this issue: [internal-branch.go1.16-vendor] module: allow '+' in package import paths (but not module paths)

@gopherbot
Copy link
Author

Change https://golang.org/cl/300153 mentions this issue: [release-branch.go1.16] cmd/go: allow '+' in package import paths in module mode

@toothrot toothrot modified the milestones: Go1.16.1, Go1.16.2 Mar 10, 2021
@cagedmantis cagedmantis modified the milestones: Go1.16.2, Go1.16.3 Mar 11, 2021
@dmitshur
Copy link
Contributor

Approving per discussion in a release meeting. Only Go 1.16 needs this backport based on the rationale.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 12, 2021
@AlexRouSg AlexRouSg mentioned this issue Mar 22, 2021
Closed
gopherbot pushed a commit to golang/mod that referenced this issue Mar 25, 2021
@toothrot
[internal-branch.go1.16-vendor] module: allow '+' in package import p…
dbbbf8a 
…aths (but not module paths)

For golang/go#44885.
Updates golang/go#44776.

Change-Id: I1bc3df2800a1765296c5164aa8bece495d8f9221
Reviewed-on: https://go-review.googlesource.com/c/mod/+/300149
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
(cherry picked from commit d6ab96f)
Reviewed-on: https://go-review.googlesource.com/c/mod/+/300152
@gopherbot
Copy link
Author

Closed by merging 2940614 to release-branch.go1.16.

gopherbot pushed a commit that referenced this issue Mar 31, 2021
@dr2chase
[release-branch.go1.16] cmd/go: allow '+' in package import paths in …
2940614 
…module mode

This change upgrades x/mod to pull in the fix from CL 300152.

Updates #44776.
Fixes #44885.

Change-Id: I273f41df2abfff76d91315b7f19fce851c8770d8
Reviewed-on: https://go-review.googlesource.com/c/go/+/300176
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
(cherry picked from commit d33e219)
Reviewed-on: https://go-review.googlesource.com/c/go/+/300153
@golang golang locked and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.16.3
Development

No branches or pull requests
5 participants
@toothrot @cagedmantis @dmitshur @bcmills @gopherbot