Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: import paths ending with '+' are rejected (affects executable like g++ or clang++) [1.15 backport] #44884

Closed
gopherbot opened this issue Mar 9, 2021 · 1 comment
Closed

cmd/go: import paths ending with '+' are rejected (affects executable like g++ or clang++) [1.15 backport] #44884

gopherbot opened this issue Mar 9, 2021 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.15.10

Comments

@gopherbot
Copy link

@bcmills requested issue #44776 to be considered for backport to the next 1.15 minor release.

@gopherbot, please backport to Go 1.16.

Go 1.16 added previously-missing path validation paths and enabled module mode by default, both of which made this check much more likely to be triggered.

I don't think this needs to be backported to Go 1.15. In 1.15, the go command had a bug that caused these paths not to be diagnosed if they are already present in some module in the build list. That bug was incidentally fixed in CL 258298 for Go 1.16. (This issue was exposed by the combination of fixing that bug and enabling module mode by default in Go 1.16.)
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 9, 2021
@gopherbot gopherbot mentioned this issue Mar 9, 2021
Closed
@gopherbot gopherbot added this to the Go1.15.9 milestone Mar 9, 2021
@bcmills bcmills closed this as completed Mar 9, 2021
@bcmills
Copy link
Contributor

bcmills commented Mar 9, 2021 •
edited

As noted in my comment, I don't think this needs to be backported to 1.15. (Bad bot! #27489!)

@bcmills bcmills mentioned this issue Mar 9, 2021
Open
@toothrot toothrot modified the milestones: Go1.15.9, Go1.15.10 Mar 10, 2021
@dmitshur dmitshur removed the CherryPickCandidate Used during the release process for point releases label Mar 11, 2021
@golang golang locked and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.15.10
Development

No branches or pull requests
4 participants
@toothrot @dmitshur @bcmills @gopherbot