Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: update docs for Parallel, -cpus flag #4488

Closed
bcmills opened this issue Dec 4, 2012 · 5 comments
Closed

testing: update docs for Parallel, -cpus flag #4488

bcmills opened this issue Dec 4, 2012 · 5 comments
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 4, 2012

The documentation for testing.T.Parallel (http://golang.org/pkg/testing/#T.Parallel)
says it is "to be run in parallel with (and only with) other parallel tests in this
CPU group".

Nothing on golang.org says what a "CPU group" is or how one determines which
tests are in it.
(https://www.google.com/search?q=";CPU+group"+site%3Agolang.org
@kylelemons
Copy link
Contributor

Comment 1:

When it says "CPU group" it means the group of tests that are running on a particular
number of CPUs.  It's relevant when you specify -test.cpus=1,2,4,8 and such to "go
test."  It looks like the documentation for "go test" and package "testing" omit the
flags, but you can see the flag here:
http://golang.org/src/pkg/testing/testing.go#L109

@rsc
Copy link
Contributor

rsc commented Dec 10, 2012

Comment 2:

Fix:
1. s/ in this CPU group//
2. add -cpus flag to go help testflag and package testing docs.

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Dec 10, 2012

Comment 3:

Labels changed: added size-s.

@rsc
Copy link
Contributor

rsc commented Dec 10, 2012

Comment 4:

Labels changed: added suggested.

@rsc
Copy link
Contributor

rsc commented Feb 4, 2013

Comment 5:

This issue was closed by revision 89a2a8c.

Status changed to Fixed.

@bcmills bcmills added fixed Suggested Issues that may be good for new contributors looking for work to do. labels Feb 4, 2013
@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Development

No branches or pull requests

4 participants