reflect: no efficient way to append to, or grow, a slice #44870
Labels
FrozenDueToAge
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Comments
ianlancetaylor
added
the
NeedsInvestigation
|
If there will be something to do here, I think it would be a good chance to make slice grow implementation in reflection and non-reflection consistent: #41239 (comment) |
|
What is "efficient"? It's possible to grow a slice with the reflect package using more primitive mechanisms. Is it worth providing a special case for that operation? How does one decide what reflect should optimize for? |
|
Previous discussion about Append allocating a new slice header (in addition to potentially a new backing array) always and generally making reflect allocate less: #32424 (comment) |
|
Sorry, I got confused here. I think the reflect package is fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is based on https://groups.google.com/g/golang-nuts/c/S2gBW3BV4QU/m/mSPh2_FzBgAJ :
The reflect package has no efficient way to append to a slice represented as a
reflect.Value. This is available in the reflect2 package: https://pkg.go.dev/github.com/modern-go/reflect2#UnsafeSliceType.Append. The reflect2 package also has a method to grow a slice to a new size: https://pkg.go.dev/github.com/modern-go/reflect2#UnsafeSliceType.Grow.The text was updated successfully, but these errors were encountered: