Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: diagnostics shown for builtin.go #44866

Closed
mreza0100 opened this issue Mar 8, 2021 · 4 comments
Closed

x/tools/gopls: diagnostics shown for builtin.go #44866

mreza0100 opened this issue Mar 8, 2021 · 4 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
gopls on-deck
Milestone
gopls/v0.8.0

Comments

@mreza0100
Copy link

I don't know if this is a bug or...
if I go to build in source code, for example ctrl + click on string type then I will see 51 errors on golang build in types
Screenshot from 2021-03-08 20-21-31

Information about Go version and etc is attached in information.txt file
information.txt
@mreza0100 mreza0100 changed the title erros in build in library errors in build in library Mar 8, 2021
@stamblerre stamblerre transferred this issue from golang/vscode-go Mar 8, 2021
@stamblerre stamblerre changed the title errors in build in library x/tools/gopls: diagnostics shown for builtin.go Mar 8, 2021
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Mar 8, 2021
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 8, 2021
@stamblerre
Copy link
Contributor

Thanks for the report, @mreza0100! This is definitely a bug.

@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.6.8 Mar 11, 2021
@stamblerre stamblerre added this to To Do in gopls on-deck Apr 15, 2021
@gopherbot
Copy link

Change https://golang.org/cl/314290 mentions this issue: internal/lsp: don't call PackagesForFile on builtin.go

gopls on-deck automation moved this from To Do to Done Apr 29, 2021
@findleyr findleyr reopened this Feb 15, 2022
gopls on-deck automation moved this from Done to To Do Feb 15, 2022
@findleyr
Copy link
Contributor

findleyr commented Feb 15, 2022 •
edited

I think we need to do more to suppress these diagnostics.

We should suppress all type-checking errors for the builtin package.

@findleyr findleyr modified the milestones: gopls/v0.6.11, gopls/v0.8.1 Feb 15, 2022
mattheusv added a commit to mattheusv/tools that referenced this issue Feb 17, 2022
@mattheusv
internal/lsp: don't diagnostic builtin.go
2256dbf 
Fixes golang/go#44866
@mattheusv mattheusv mentioned this issue Feb 17, 2022
Closed
@gopherbot
Copy link

Change https://go.dev/cl/386219 mentions this issue: internal/lsp: don't diagnostic builtin.go

mattheusv added a commit to mattheusv/tools that referenced this issue Feb 18, 2022
@mattheusv
internal/lsp: don't store diagnostics for builtin.go
e6f525e 
Fixes golang/go#44866
@findleyr findleyr modified the milestones: gopls/v0.8.1, gopls/v0.8.0 Feb 23, 2022
gopls on-deck automation moved this from To Do to Done May 10, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
No open projects
gopls on-deck
Done
Milestone
gopls/v0.8.0
Development

Successfully merging a pull request may close this issue.

internal/lsp: don't store diagnostics for builtin.go mattheusv/tools
4 participants
@stamblerre @gopherbot @findleyr @mreza0100