Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: Broken links on pkg.go.dev to codeberg.org repositories. #44865

Closed
catinello opened this issue Mar 8, 2021 · 3 comments
Closed

x/pkgsite: Broken links on pkg.go.dev to codeberg.org repositories. #44865

catinello opened this issue Mar 8, 2021 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite

Comments

@catinello
Copy link

What is the URL of the page with the issue?

Any page on pkg.go.dev that has links resolving to repositories on codeberg.org. That issue may affect all gitea hosted repositories.

What is your user agent?

Issue is not user-agent related.

Screenshot

What did you do?

Click on a link that resolves to a file at a codeberg.org repo.

Go to https://pkg.go.dev/codeberg.org/ac/ecdh25519#section-sourcefiles and take a look at the link for the file ecdh25519.go.

It refers to https://codeberg.org/ac/ecdh25519/src/commit/8a2cf2a5c93c/ecdh25519.go

If you call that link, you'll receive a 404:

$ curl -I https://codeberg.org/ac/ecdh25519/src/commit/8a2cf2a5c93c/ecdh25519.go
HTTP/2 404
...

At first it looks like an server issue, but it is not necessarily.

The correct permalink is however https://codeberg.org/ac/ecdh25519/src/commit/8a2cf2a5c93c3fb69f0e6161f4bb82dccc3584b0/ecdh25519.go

Please spot the difference in the given commit hash value. One (defined in the link on pkg.go.dev) is abbreviated, the other is in long notation (correct destination on codeberg.org).

What did you expect to see?

I expected to reach the linked target file.

What did you see instead?

404

@gopherbot gopherbot added this to the Unreleased milestone Mar 8, 2021
@ALTree ALTree added Documentation NeedsFix The path to resolution is known, but the work has not been done. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed NeedsFix The path to resolution is known, but the work has not been done. labels Mar 8, 2021
@jamalc jamalc modified the milestones: Unreleased, pkgsite/unplanned Mar 8, 2021
@julieqiu
Copy link
Member

julieqiu commented Mar 8, 2021

Related: #40477

@catinello
Copy link
Author

I just got notified by a gitea developer that the problem is known. They fixed it in the development branch and the fix will be available in the next release (1.14).

So this issue may be closed in the meantime.

https://codeberg.org/Codeberg/Community/issues/413

@julieqiu
Copy link
Member

julieqiu commented Mar 8, 2021

Thanks for letting us know, @catinello!

@julieqiu julieqiu closed this as completed Mar 8, 2021
@golang golang locked and limited conversation to collaborators Mar 8, 2022
@rsc rsc unassigned jba Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Development

No branches or pull requests

6 participants