Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/windows: add HeapAlloc and related functions #44845

Open
ericlagergren opened this issue Mar 7, 2021 · 2 comments
Open

x/sys/windows: add HeapAlloc and related functions #44845

ericlagergren opened this issue Mar 7, 2021 · 2 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FeatureRequest NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. OS-Windows
Milestone
Unreleased

Comments

@ericlagergren
Copy link
Contributor

x/sys/windows has LocalAlloc and VirtualAlloc, but not HeapAlloc. HeapAlloc is generally recommended over using LocalAlloc and should be used when you're allocating memory that's not page sized.

Would necessitate HeapCreate and HeapFree.
@gopherbot gopherbot added this to the Unreleased milestone Mar 7, 2021
@ALTree ALTree added FeatureRequest NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Mar 8, 2021
@networkimprov
Copy link

networkimprov commented Mar 9, 2021 •
edited

cc @alexbrainman @zx2c4

@gopherbot add OS-Windows

@zx2c4
Copy link
Contributor

zx2c4 commented Mar 9, 2021

What APIs actually require these? Some APIs expect local-allocated memory or return local-allocated memory. But what about the Heap functions?

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FeatureRequest NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. OS-Windows
Projects
Go Compiler / Runtime
Status: Triage Backlog
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@zx2c4 @networkimprov @ALTree @ericlagergren @gopherbot