Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: remove link to go.mod when file does not exist #44837

Closed
julieqiu opened this issue Mar 7, 2021 · 1 comment
Closed

x/pkgsite: remove link to go.mod when file does not exist #44837

julieqiu opened this issue Mar 7, 2021 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Milestone
pkgsite/frontend

Comments

@julieqiu
Copy link
Member

julieqiu commented Mar 7, 2021

What is the URL of the page with the issue?

https://pkg.go.dev/mvdan.cc/sh/syntax

Screenshot

image

What did you do?

Click on the "go.mod" link in "Valid go.mod file", which takes you to https://github.com/mvdan/sh/tree/v1.3.1/go.mod.

What did you expect to see?

No clickable link in "Valid go.mod file", since there is an X next to the item.

What did you see instead?

A link to https://github.com/mvdan/sh/tree/v1.3.1/go.mod, which returns a 404.

/cc @jamalc
@gopherbot gopherbot added this to the Unreleased milestone Mar 7, 2021
@julieqiu julieqiu added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 7, 2021
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/frontend Mar 7, 2021
@gopherbot
Copy link

Change https://golang.org/cl/309391 mentions this issue: content/static: remove link to go.mod when file does not exist

@golang golang locked and limited conversation to collaborators Apr 13, 2022
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
@rsc rsc unassigned jamalc Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
4 participants
@hyangah @julieqiu @gopherbot @jamalc