Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: page with the stdlib code is not UX-friendly (as it was before) #44832

Closed
cristaloleg opened this issue Mar 6, 2021 · 6 comments
Closed
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite

Comments

@cristaloleg
Copy link

cristaloleg commented Mar 6, 2021

What is the URL of the page with the issue?

https://pkg.go.dev/encoding/base64#Encoding.Decode which redirects to
https://go.googlesource.com/go/+/go1.16/src/encoding/base64/base64.go

But it doesn't matter, 'cause the problem is related to https://go.googlesource.com

What is your user agent?

  • Mozilla/5.0 (Macintosh; Intel Mac OS X 11_2_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.72 Safari/537.36
  • Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:86.0) Gecko/20100101 Firefox/86.0
  • Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0.3 Safari/605.1.15

Screenshot

Nothing to show.

What did you do?

I would like to see the source code for some stdlib packages. https://pkg.go.dev now redirects to https://go.googlesource.com but https://godoc.org (and early pkg.go.dev ?) has redirected to https://github.com

What did you expect to see?

Same features as on Github:

  • download 'raw' code
  • manually copy the whole file
  • see commits history
  • see git blame
  • file history (commits, links to the issues and so on)

What did you see instead?

Sadly current UX and UI looks like this:

  • Link to the raw code (named 'txt' at the end of the page) gives base64 of the file, which is a strange format for the code (txt!) to be read by a human.
  • Manual copy removes empty lines (same behaviour between 3 browsers, no addons) (UPD: copy file content on the page, paste into IDE or any other editor)
  • No link to commits
  • No link to git blame
  • Nothing at all :(

I understand why Go stdlib is served via https://go.googlesource.com but still it's too feature limited to make daily work easy and simple.

Thank you.

UPD: updated after #44832 (comment) comment, my bad.

@gopherbot gopherbot added this to the Unreleased milestone Mar 6, 2021
@fzipp
Copy link
Contributor

fzipp commented Mar 6, 2021

Link to the raw code (named 'txt' at the end of the page) gives base64 of the file, which is a strange format for the code (txt!) to be read by a human.
Manual copy removes empty lines (same behaviour between 3 browsers, no addons)
No link to commits
No link to git blame
Nothing at all :(

Not sure what you mean. I see all of this:

git-blame-etc

@cristaloleg
Copy link
Author

cristaloleg commented Mar 6, 2021

@fzipp my bad, they're presented there.

[log] and [blame] work as expected (however links to the issue aren't supported, just golang/goXXX or #XXX).

[file] redirects to the same page, but not a raw file as expected (only by me?)

@tmthrgd
Copy link
Contributor

tmthrgd commented Mar 6, 2021

This and #44829 are duplicates. (This issue has more engagement and detail from what I can tell).

@jamalc jamalc added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 8, 2021
@jamalc jamalc modified the milestones: Unreleased, pkgsite/unplanned Mar 8, 2021
@seankhliao
Copy link
Member

an option would be codesearch: https://cs.opensource.google/go which I think has better linking

@cristaloleg
Copy link
Author

@seankhliao even better!

@gopherbot
Copy link

Change https://golang.org/cl/318873 mentions this issue: internal: change stdlib source repo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Development

No branches or pull requests

6 participants