Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: change stdlib's documentation source repo to GitHub? #44829

Closed
aofei opened this issue Mar 6, 2021 · 4 comments
Closed

x/pkgsite: change stdlib's documentation source repo to GitHub? #44829

aofei opened this issue Mar 6, 2021 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone
pkgsite/unplanned

Comments

@aofei
Copy link
Contributor

aofei commented Mar 6, 2021 •
edited

The current documentation source repo of the stdlib is https://go.googlesource.com/go, which is fine. But to be honest, when it comes to code browsing, I think Gitiles lacks some handy features compared to GitHub. Like better syntax highlighting, code reference and code navigation.

So, since the documentation source repo of most modules in pkg.go.dev are on GitHub (including golang.org/x/...), maybe stdlib can do the same (for better code browsing).

Just a suggestion. 🙂

/cc @julieqiu
@gopherbot gopherbot added this to the Unreleased milestone Mar 6, 2021
@fsouza
Copy link
Contributor

fsouza commented Mar 6, 2021

The stdlib is already on github. https://github.com/golang/go is a mirror of https://go.googlesource.com/go.

@aofei
Copy link
Contributor Author

aofei commented Mar 6, 2021

@fsouza

Sorry, that was not what I meant. I mean the documentation source. For example, the http.Request's documentation source is currently https://go.googlesource.com/go/+/go1.16/src/net/http/request.go#102 instead of https://github.com/golang/go/blob/go1.16/src/net/http/request.go#L102.

@aofei aofei changed the title x/pkgsite: change stdlib's source repo to GitHub? x/pkgsite: change stdlib's documentation source repo to GitHub? Mar 6, 2021
@fsouza
Copy link
Contributor

fsouza commented Mar 6, 2021

@aofei ohh gotcha. Sorry for the confusion, my bad

@tmthrgd tmthrgd mentioned this issue Mar 6, 2021
Closed
@jamalc jamalc added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 8, 2021
@jamalc jamalc modified the milestones: Unreleased, pkgsite/unplanned Mar 8, 2021
@julieqiu
Copy link
Member

julieqiu commented Mar 8, 2021

Closing this as a duplicate of #44832.

@julieqiu julieqiu closed this as completed Mar 8, 2021
@golang golang locked and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
5 participants
@fsouza @aofei @julieqiu @gopherbot @jamalc