Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: markdown parsing of code inside a link #44798

Closed
jakesylvestre opened this issue Mar 4, 2021 · 4 comments
Closed

x/pkgsite: markdown parsing of code inside a link #44798

jakesylvestre opened this issue Mar 4, 2021 · 4 comments
Labels
FrozenDueToAge pkgsite WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
pkgsite/unplanned

Comments

@jakesylvestre
Copy link

What did you do?

Currently, on say github I can wrap a link inside a code block like so. I did this on github.com/xplorfin/netutils.

What did you expect to see?

This to render correctly on pkg.go.dev like above.

What did you see instead?

See here for original link
image
@gopherbot gopherbot added this to the Unreleased milestone Mar 4, 2021
@julieqiu
Copy link
Member

julieqiu commented Mar 5, 2021

Would you mind clarifying where the issue is? Here's what I see on:

https://github.com/xplorfin/netutils:

image

and https://pkg.go.dev/github.com/xplorfin/netutils:

image

@julieqiu julieqiu added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Mar 5, 2021
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/unplanned Mar 5, 2021
@jakesylvestre
Copy link
Author

jakesylvestre commented Mar 7, 2021 •
edited

Yep! I'm on mobile right now so I just circled it in your screenshot:
image

@seankhliao
Copy link
Member

seems like a bug in the project's readme, it's currently

`mock_test`[testutils/mock_test]

when it should be

[`mock_test`](testutils/mock_test)

note httmock a few lines above has the correct syntax/renders properly

@jakesylvestre
Copy link
Author

Got it - was looking at a local version with that fixed. Thanks!

@golang golang locked and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge pkgsite WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
4 participants
@julieqiu @jakesylvestre @gopherbot @seankhliao