New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/exp/cmd/apidiff: incorrectly reports breaking change on numeric const using scientific e-notation #44796
Comments
CC @jba |
I think it might be on the export side of things - because the "new" side of the diff outputs the proper value, while the "old" side (I think loaded from the exported data) is reported as the mangled value. It could be that the constant value is incorrectly written at export, or incorrectly read at compat check. Since |
When I use a local install of This is also with a local install of |
Updating the |
I checked out golang/tools@a1db63c locally (still wired with The pseudo version for that Worth noting that some other deps in
|
It was fixed by commit b79f76f, CL b79f76f |
Ok, good to know the exact fix, but that commit hasn't been released. Is it possible to cut a release of the root module in |
@ianthehat Hi would it be possible to cut a release of the |
What version of Go are you using (
go version
)?Also happens on
go version go1.16 linux/amd64
.Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (
go env
)?go env
OutputAlso happens on
linux/amd64
.What did you do?
go install golang.org/x/exp/cmd/apidiff@latest git clone https://github.com/googleapis/google-cloud-go gocloud cd gocloud/pubsub apidiff -w pkg.master cloud.google.com/go/pubsub apidiff -incompatible pkg.master cloud.google.com/go/pubsub
What did you expect to see?
Nothing, no breaking changes.
What did you see instead?
The LoC in question is here.
In short, it reads:
We are trying to (re)enable
apidiff
incloud.google.com/go
CI, but can't enable it until this is fixed. We can always workaround this specific error though, I guess.The text was updated successfully, but these errors were encountered: