-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/go/buildutil: support comma-delimited build tags in buildutil.TagsFlag #44787
Comments
I note, per https://tip.golang.org/cmd/go/#hdr-Compile_packages_and_dependencies:
So this seems fine to add to |
Change https://golang.org/cl/284214 mentions this issue: |
Any update on this? We'd like to support commas in build tags in TinyGo and it would be really nice if we could keep using |
Seems like https://golang.org/cl/284214 has been languishing. Would you be willing to nudge it across the finish line (in other words, take it over)? It doesn't look very hard. |
I'll pick this up. |
Change https://go.dev/cl/558115 mentions this issue: |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
I would like to allow tools in the community to support the same format for build tags (e.g. comma delimited) as the go tool supports. Space separate tags have been deprecated in the go tool. This brings parity to tools that rely on golang.org/x/tools/go/build : see https://go-review.googlesource.com/c/tools/+/284214#message-fc9907b03ae75ae24145f421e623330b4b9b9158
The text was updated successfully, but these errors were encountered: