Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: dead anchor in download page #44780

Closed
ALTree opened this issue Mar 4, 2021 · 4 comments
Closed

x/website: dead anchor in download page #44780

ALTree opened this issue Mar 4, 2021 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@ALTree
Copy link
Member

ALTree commented Mar 4, 2021

https://golang.org/dl/ says:

See https://proxy.golang.org/privacy for privacy information about these services and the go command documentation for configuration details including how to disable the use of these servers or use different ones.

The link on go command documentation points to https://golang.org/cmd/go/#hdr-Module_downloading_and_verification, but no such anchor exists at that page.

cc @dmitshur @stevetraut

@ALTree ALTree added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 4, 2021
@gopherbot gopherbot added this to the Unreleased milestone Mar 4, 2021
@gopherbot
Copy link

Change https://golang.org/cl/299129 mentions this issue: internal/dl: fix links to Modules PROXY configuration

@dmitshur
Copy link
Contributor

Perhaps https://golang.org/cmd/go/#hdr-Configuration_for_downloading_non_public_code is a good place to consider linking to instead. That section gives a high level overview and links to https://golang.org/ref/mod at the bottom for more details.

CC @katiehockman, @jayconrod.

@ALTree
Copy link
Member Author

ALTree commented Mar 17, 2021

The phrasing on the download page is

See [link] for privacy information [...] and the go command documentation for configuration details including how to disable the use of these servers or use different ones.

I read this as "look, we use these Google servers by default and they log stuff, go there if you want to learn how to avoid this"; in other words we're not really talking about private code/modules (which is the focus of the section you suggest to link, which is titled "Configuration for downloading non-public code"); but actually about how to disable or change what servers the go toolchain talks to (for any code, public or private modules). That's why I choose to link to https://golang.org/ref/mod#module-proxy, which is a less friendly but also more general section of the doc that clearly lays out the variables that can be set to change the go command behaviour (including turning off stuff).

On the other hand I agree that the section you suggest to link looks a little bit friendlier, while the one I suggested we link to in the CL is more technical.

I don't have any strong preference, so if you decide to link to the other one let me know and I'll update the CL.

@dmitshur
Copy link
Contributor

Right, the link I mentioned would be better if the "how to disable the use of" part was linked, but it's not.

My suggestion for CL 299129 would be to a minimal change that removes the (broken) anchor, leaving the link to the go command documentation, where "configuration details" are indeed described.

@golang golang locked and limited conversation to collaborators Mar 18, 2022
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
The downloads page has a link pointing to a section about module proxy
servers in the cmd/go doc that was removed in CL 282615. Remove the
anchor.

Fixes golang/go#44780

Change-Id: Ifb7f4f991b3314a3cda6d00d77925401a8830456
Reviewed-on: https://go-review.googlesource.com/c/website/+/299129
Trust: Alberto Donizetti <alb.donizetti@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants