Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: Share link doesn't update with the associated code #44719

Closed
katiehockman opened this issue Mar 1, 2021 · 1 comment
Closed

x/pkgsite: Share link doesn't update with the associated code #44719

katiehockman opened this issue Mar 1, 2021 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
pkgsite/golang.or...

Comments

@katiehockman
Copy link
Contributor

Repro:

The provided link is to the original code from the example, rather than the (potentially) updated version of the code that was changed locally. For example, see the following example which I updated on pkg.go.dev, and see that the code in the provided link doesn't include the changes that I made. (https://play.golang.org/p/4DJiqPxGi1J)

image

/cc @julieqiu @jamalc @jba
@katiehockman katiehockman added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite labels Mar 1, 2021
@julieqiu julieqiu added this to the pkgsite/golang.org-features milestone Mar 1, 2021
@findleyr findleyr changed the title pkgsite: Share link doesn't update with the associated code x/pkgsite: Share link doesn't update with the associated code Mar 2, 2021
@jamalc jamalc added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 2, 2021
@gopherbot
Copy link

Change https://golang.org/cl/297874 mentions this issue: content/static: make playground share links update with edited text

@golang golang locked and limited conversation to collaborators Mar 3, 2022
@rsc rsc unassigned jamalc Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
pkgsite/golang.org-features
Development

No branches or pull requests
4 participants
@julieqiu @gopherbot @jamalc @katiehockman