Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: handle conflicting replaces in the workspace module #44698

Closed
stamblerre opened this issue Feb 28, 2021 · 1 comment
Closed

x/tools/gopls: handle conflicting replaces in the workspace module #44698

stamblerre opened this issue Feb 28, 2021 · 1 comment
Labels
FrozenDueToAge gopls/workspace Issues related to support for modules or multi-module workspaces. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
gopls on-deck
Milestone
gopls/backlog

Comments

@stamblerre
Copy link
Contributor

stamblerre commented Feb 28, 2021 •
edited

When the workspace module replaces 2+ different versions of the same dependency, we should prefer the highest version. We should also prefer file replaces to version replaces.

What should we do if there are multiple file replaces?
@stamblerre stamblerre added this to the gopls/workspace-module milestone Feb 28, 2021
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 28, 2021
@stamblerre stamblerre changed the title x/tools/gopls: prefer higher versions when encountering conflicts in workspace module x/tools/gopls: handle conflicting replaces in the workspace module Feb 28, 2021
@stamblerre stamblerre added this to To Do in gopls on-deck Feb 28, 2021
@suzmue suzmue added the gopls/workspace Issues related to support for modules or multi-module workspaces. label May 10, 2022
@findleyr
Copy link
Contributor

I don't think we're going to do this, since the workspace module is deprecated. go.work files have their own handling for this.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Jul 1, 2022
@golang golang locked and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls/workspace Issues related to support for modules or multi-module workspaces. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
No open projects
gopls on-deck
To Do
Milestone
gopls/backlog
Development

No branches or pull requests
4 participants
@stamblerre @suzmue @gopherbot @findleyr