Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: warning message when getting a retracted module version is missing a trailing newline [1.16 backport] #44676

Closed
gopherbot opened this issue Feb 28, 2021 · 3 comments
Closed

cmd/go: warning message when getting a retracted module version is missing a trailing newline [1.16 backport] #44676

gopherbot opened this issue Feb 28, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.16.2

Comments

@gopherbot
Copy link

@ALTree requested issue #44674 to be considered for backport to the next 1.16 minor release.

@gopherbot Please open a 1.16 backport issue for consideration. This is a garbled user-visibile message with no workaround.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 28, 2021
@gopherbot gopherbot mentioned this issue Feb 28, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.1 milestone Feb 28, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/297633 mentions this issue: [release-branch.go1.16] cmd/go: add missing newline to retraction warning message

@dmitshur
Copy link
Contributor

dmitshur commented Mar 1, 2021

Approved. This is improving the readability of user-facing documentation for a newly added feature, and the fix is very safe. Only Go 1.16 needs this backport.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 1, 2021
@gopherbot
Copy link
Author

Closed by merging 2b7243a to release-branch.go1.16.

gopherbot pushed a commit that referenced this issue Mar 1, 2021
@liggitt @dmitshur
[release-branch.go1.16] cmd/go: add missing newline to retraction war…
2b7243a 
…ning message

Updates #44674
Fixes #44676

Change-Id: Icbdb79084bf7bd2f52cc0a53abcc1ec6f0c4a1bf
Reviewed-on: https://go-review.googlesource.com/c/go/+/297350
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Jay Conrod <jayconrod@google.com>
(cherry picked from commit 87beecd)
Reviewed-on: https://go-review.googlesource.com/c/go/+/297633
Trust: Bryan C. Mills <bcmills@google.com>
@toothrot toothrot modified the milestones: Go1.16.1, Go1.16.2 Mar 10, 2021
@bcmills bcmills mentioned this issue Mar 11, 2021
Closed
@golang golang locked and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.16.2
Development

No branches or pull requests
3 participants
@toothrot @dmitshur @gopherbot