Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: failed to run make.bash on darwin arm64 #44675

Closed
cuonglm opened this issue Feb 28, 2021 · 8 comments
Closed

all: failed to run make.bash on darwin arm64 #44675

cuonglm opened this issue Feb 28, 2021 · 8 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone

Comments

@cuonglm
Copy link
Member

cuonglm commented Feb 28, 2021

What version of Go are you using (go version)?

$ go version

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

What did you do?

$ GOROOT_BOOTSTRAP=/Users/cuonglm/sdk/go1.16 ./make.bash
Building Go cmd/dist using /Users/cuonglm/sdk/go1.16. (go1.16 darwin/arm64)
Building Go toolchain1 using /Users/cuonglm/sdk/go1.16.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
go tool dist: FAILED: /Users/cuonglm/sources/go/pkg/tool/darwin_arm64/go_bootstrap install -gcflags=all= -ldflags=all= -i cmd/asm cmd/cgo cmd/compile cmd/link: signal: segmentation fault

What did you expect to see?

make.bash run successfully.

What did you see instead?

make.bash failed after commit 5ff7ec9

cc @dr2chase @jeremyfaller @cherrymui

@cuonglm
Copy link
Member Author

cuonglm commented Feb 28, 2021

FYI, using the bootstrap binary produces the same error:

GOROOT_BOOTSTRAP=$(pwd)/../../go-darwin-arm64-bootstrap ./make.bash

@Rajalakshmi-Girish
Copy link

Also observed on ppc64le:

[root@rajalakshmi-workspace ~]# go version
go version go1.15.8 linux/ppc64le
[root@rajalakshmi-workspace ~]# git clone https://github.com/golang/go.git
Cloning into 'go'...
remote: Enumerating objects: 29, done.
remote: Counting objects: 100% (29/29), done.
remote: Compressing objects: 100% (28/28), done.
remote: Total 463350 (delta 2), reused 1 (delta 1), pack-reused 463321
Receiving objects: 100% (463350/463350), 238.53 MiB | 26.31 MiB/s, done.
Resolving deltas: 100% (370164/370164), done.
Checking out files: 100% (9735/9735), done.
[root@rajalakshmi-workspace ~]# cd go/src/
[root@rajalakshmi-workspace src]# ./make.bash
Building Go cmd/dist using /usr/local/go. (go1.15.8 linux/ppc64le)
Building Go toolchain1 using /usr/local/go.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
go tool dist: FAILED: /root/go/pkg/tool/linux_ppc64le/go_bootstrap install -gcflags=all= -ldflags=all= -i cmd/asm cmd/cgo cmd/compile cmd/link: signal: segmentation fault (core dumped)
[root@rajalakshmi-workspace src]#

@Rajalakshmi-Girish
Copy link

Rajalakshmi-Girish commented Mar 1, 2021

@cuonglm Can you please make the issue summary more generic to include power architecture?
linux/ppc64le

@cuonglm
Copy link
Member Author

cuonglm commented Mar 1, 2021

@cuonglm Can you please make the issue summary more generic to include power architecture?
linux/ppc64le

I think it’s ok to add more failure in comments. Also there’s note in original CL https://go-review.googlesource.com/c/go/+/293392

@erifan
Copy link

erifan commented Mar 1, 2021

Also observed on Linux/Arm64

@jcajka
Copy link
Contributor

jcajka commented Mar 1, 2021

I have observed this on all non-intel arches supported by Fedora, that being linux/arm64, linux/arm32, linux/s390x and linux/ppc64le with various bootstrap GC versions, gcc&co. That makes me believe this is some internal GC issues introduce somewhere between Feb 27th and now based on builds that I periodically run. Trying to bisect it now. Already bisected by the original reporter.

@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Mar 1, 2021
@bcmills bcmills added this to the Go1.17 milestone Mar 1, 2021
@gopherbot
Copy link

Change https://golang.org/cl/297549 mentions this issue: Revert "cmd/compile: check frame offsets against abi"

@gopherbot
Copy link

Change https://golang.org/cl/297637 mentions this issue: cmd/compile: better version of check frame offsets against abi

gopherbot pushed a commit that referenced this issue Mar 2, 2021
improved to run on more architectures.

this is in preparation for turning off calculation of frame offsets
in types.CalcSize.

Replaces https://go-review.googlesource.com/c/go/+/293392 .
Updates #44675.
For #40724.

Change-Id: I40ba496172447cf09b86bc646148859363c11ad9
Reviewed-on: https://go-review.googlesource.com/c/go/+/297637
Trust: David Chase <drchase@google.com>
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
@golang golang locked and limited conversation to collaborators Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Development

No branches or pull requests

6 participants