Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: warning message when getting a retracted module version is missing a trailing newline #44674

Closed
liggitt opened this issue Feb 28, 2021 · 5 comments
Closed

cmd/go: warning message when getting a retracted module version is missing a trailing newline #44674

liggitt opened this issue Feb 28, 2021 · 5 comments
Labels
FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.17

Comments

@liggitt
Copy link
Contributor

liggitt commented Feb 28, 2021 •
edited

What version of Go are you using (go version)?

$ go version

go version go1.16 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What did you do?

Used go get to fetch a retracted module version

$ go mod init testcase
go: creating new go.mod: module testcase

$ go get github.com/liggitt/retract20210126@v1.5.2
go: warning: github.com/liggitt/retract20210126@v1.5.2: retracted by module author: pre-module versions are obsolete
go: to switch to the latest unretracted version, run:
	go get github.com/liggitt/retract20210126@latestgo get: added github.com/liggitt/retract20210126 v1.5.2

What did you expect to see?

A well-formed warning about the retracted version

What did you see instead?

A missing newline garbled the command to run to switch to the latest version:

	go get github.com/liggitt/retract20210126@latestgo get: added github.com/liggitt/retract20210126 v1.5.2
@liggitt
Copy link
Contributor Author

liggitt commented Feb 28, 2021 •
edited

looks like the newline was dropped in https://go-review.googlesource.com/c/go/+/282121

@gopherbot
Copy link

Change https://golang.org/cl/297350 mentions this issue: cmd/go: add missing newline to retraction warning message

@ALTree
Copy link
Member

ALTree commented Feb 28, 2021

@gopherbot Please open a 1.16 backport issue for consideration. This is a garbled user-visibile message with no workaround.

@ALTree ALTree added this to the Go1.17 milestone Feb 28, 2021
@ALTree ALTree added NeedsFix The path to resolution is known, but the work has not been done. modules labels Feb 28, 2021
@gopherbot gopherbot mentioned this issue Feb 28, 2021
Closed
@gopherbot
Copy link

Backport issue(s) opened: #44676 (for 1.16).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@jayconrod jayconrod self-assigned this Mar 1, 2021
@gopherbot
Copy link

Change https://golang.org/cl/297633 mentions this issue: [release-branch.go1.16] cmd/go: add missing newline to retraction warning message

gopherbot pushed a commit that referenced this issue Mar 1, 2021
@liggitt @dmitshur
[release-branch.go1.16] cmd/go: add missing newline to retraction war…
2b7243a 
…ning message

Updates #44674
Fixes #44676

Change-Id: Icbdb79084bf7bd2f52cc0a53abcc1ec6f0c4a1bf
Reviewed-on: https://go-review.googlesource.com/c/go/+/297350
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Jay Conrod <jayconrod@google.com>
(cherry picked from commit 87beecd)
Reviewed-on: https://go-review.googlesource.com/c/go/+/297633
Trust: Bryan C. Mills <bcmills@google.com>
@bcmills bcmills mentioned this issue Mar 11, 2021
Closed
@golang golang locked and limited conversation to collaborators Mar 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
4 participants
@jayconrod @liggitt @ALTree @gopherbot