You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
stamblerre opened this issue
Feb 26, 2021
· 0 comments
Labels
goplsIssues related to the Go language server, gopls.TestingAn issue that has been verified to require only test changes, not just a test failure.ToolsThis label describes issues relating to any tools in the x/tools repository.
Currently, regression tests allow you to match on a single diagnostic in a file without specifying its message. This can lead to us matching the wrong diagnostic or applying the wrong quick fixes.
Whenever we wait for diagnostics, we should wait for all of the diagnostics in the file to ensure we're not producing duplicates or new diagnostics. We should also always require the diagnostic message in all cases.
Finally, we should require a single diagnostic when we apply quick fixes, instead of applying all of the quick fixes available.
/cc @heschik
The text was updated successfully, but these errors were encountered:
gopherbot
added
Tools
This label describes issues relating to any tools in the x/tools repository.
gopls
Issues related to the Go language server, gopls.
labels
Feb 26, 2021
stamblerre
added
the
Testing
An issue that has been verified to require only test changes, not just a test failure.
label
Jun 28, 2021
goplsIssues related to the Go language server, gopls.TestingAn issue that has been verified to require only test changes, not just a test failure.ToolsThis label describes issues relating to any tools in the x/tools repository.
Currently, regression tests allow you to match on a single diagnostic in a file without specifying its message. This can lead to us matching the wrong diagnostic or applying the wrong quick fixes.
Whenever we wait for diagnostics, we should wait for all of the diagnostics in the file to ensure we're not producing duplicates or new diagnostics. We should also always require the diagnostic message in all cases.
Finally, we should require a single diagnostic when we apply quick fixes, instead of applying all of the quick fixes available.
/cc @heschik
The text was updated successfully, but these errors were encountered: