Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: runtime crash, unexpected fault address 0xffffffffffffffff, h2_bundle.go, when using plugin [1.16 backport] #44638

Closed
gopherbot opened this issue Feb 26, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone

Comments

@gopherbot
Copy link

@cherrymui requested issue #44586 to be considered for backport to the next 1.16 minor release.

@gopherbot please backport this to Go 1.16. This is a regression causing runtime crash without easy workaround.

@gopherbot
Copy link
Author

Change https://golang.org/cl/296910 mentions this issue: [release-branch.go1.16] cmd/link: handle types as converted to interface when dynlink

@dmitshur
Copy link
Contributor

dmitshur commented Mar 1, 2021

Approved. Only Go 1.16 needs this backport.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 1, 2021
gopherbot pushed a commit that referenced this issue Mar 1, 2021
…ace when dynlink

When using plugins, a type (whose value) may be pass to a plugin
and get converted to interface there, or vice versa. We need to
treat the type as potentially converted to interface, and retain
its methods.

Updates #44586.
Fixes #44638.

Change-Id: I80dd35e68baedaa852a317543ccd78d94628d13b
Reviewed-on: https://go-review.googlesource.com/c/go/+/296709
Trust: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
(cherry picked from commit a655208)
Reviewed-on: https://go-review.googlesource.com/c/go/+/296910
@gopherbot
Copy link
Author

Closed by merging a9547ad to release-branch.go1.16.

@toothrot toothrot modified the milestones: Go1.16.1, Go1.16.2 Mar 10, 2021
@golang golang locked and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

3 participants