Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/acme: TestFetchCertCancel failures with "400 Bad Request" #44611

Closed
bcmills opened this issue Feb 25, 2021 · 6 comments
Closed

x/crypto/acme: TestFetchCertCancel failures with "400 Bad Request" #44611

bcmills opened this issue Feb 25, 2021 · 6 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 25, 2021 

--- FAIL: TestFetchCertCancel (0.01s)
    acme_test.go:993: err = 400 : 400 Bad Request; want context canceled
FAIL
exitcode=1FAIL	golang.org/x/crypto/acme	106.192s

It isn't obvious to me whether this is a bug in x/crypto/acme or in the test itself.

CC @FiloSottile @katiehockman @rolandshoemaker

2021-02-20T03:31:48-5ea612d/android-amd64-emu
2020-12-08T17:14:46-5f87f34/android-amd64-emu
2020-12-03T16:30:18-be400ae/dragonfly-amd64-5_8
2020-11-24T20:17:22-c8d3bf9/android-386-emu
2020-11-17T14:41:27-c1f2f97/dragonfly-amd64
2020-11-16T15:36:03-4be66e5/android-amd64-emu
2020-11-12T15:50:50-0c6587e/dragonfly-amd64
2020-10-12T17:37:05-84dcc77/android-amd64-emu
2020-09-30T16:06:38-afb6bcd/dragonfly-amd64-5_8
2020-08-20T21:17:05-5c72a88/android-386-emu
2020-08-20T21:17:05-5c72a88/android-amd64-emu
2020-08-20T21:17:05-5c72a88/dragonfly-amd64
2020-07-09T23:00:13-948cd5f/android-386-emu
2020-07-09T23:00:13-948cd5f/android-amd64-emu
2020-07-09T23:00:13-948cd5f/dragonfly-amd64-5_8
2020-06-22T21:36:23-75b2880/android-386-emu
2020-06-04T20:27:06-70a84ac/android-386-emu
2020-04-29T18:30:12-4b2356b/dragonfly-amd64
2020-04-29T18:30:12-4b2356b/dragonfly-amd64-5_8
2020-04-23T21:15:02-4bdfaf4/android-386-emu
2020-04-14T15:58:20-4f8f47a/android-amd64-emu
2020-03-23T16:52:09-0ec3e99/android-386-emu
2020-03-20T18:11:02-891825f/linux-amd64-clang
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 25, 2021
@bcmills bcmills added this to the Backlog milestone Feb 25, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Dec 7, 2021

greplogs --dashboard -md -l -e 'FAIL: TestFetchCertCancel' --since=2021-02-27

2021-11-15T15:42:24-ceb1ce7-ce4a275/windows-arm64-10
2021-11-08T18:06:16-089bfa5-5e64755/android-386-emu
2021-11-04T00:29:42-089bfa5-a419f2f/android-amd64-emu
2021-10-26T22:05:53-089bfa5-80be4a4/android-386-emu
2021-10-07T19:49:45-089bfa5-c580180/android-amd64-emu
2021-09-20T02:37:35-84f3576-552410f/android-amd64-emu
2021-09-15T20:29:43-32db794-03df68d/android-386-emu
2021-08-13T00:12:29-0ba0e8f-1fffedd/android-amd64-emu
2021-08-05T20:22:31-a769d52-fd45e26/android-amd64-emu
2021-08-04T20:44:05-a769d52-acbe242/android-386-emu
2021-04-20T22:39:22-4f45737-c7d708e/android-386-emu
2021-03-18T21:27:24-513c2a4-095ba22/dragonfly-amd64
2021-03-17T15:28:58-513c2a4-f39c4de/linux-amd64-race
2021-03-16T21:18:43-e6e6c4f-c870e86/dragonfly-amd64
2021-03-16T21:18:43-e6e6c4f-c870e86/dragonfly-amd64-5_8

@bcmills
Copy link
Contributor Author

bcmills commented Dec 7, 2021

Given the high recent failure rate, marking as release-blocker via #11811.
(Note that at least one failure was on linux/amd64, a first-class port.)

@bcmills bcmills modified the milestones: Backlog, Go1.18 Dec 7, 2021
@bcmills bcmills added okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker labels Dec 7, 2021
@cherrymui cherrymui removed the okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 label Dec 14, 2021
@cherrymui
Copy link
Member

Seems there has been no new failure since 2021-11-15. Any update on this? Thanks. (checking in as this is a release blocker)

@bcmills
Copy link
Contributor Author

bcmills commented Jan 12, 2022

greplogs --dashboard -md -l -e 'FAIL: TestFetchCertCancel' --since=2021-12-07

2022-01-06T00:26:47-e495a2d-b5bfaf4/dragonfly-amd64
2021-12-29T20:20:32-e495a2d-6178d25/android-amd64-emu

@bcmills
Copy link
Contributor Author

bcmills commented Jan 12, 2022

This is easy to reproduce by adding a time.Sleep before the cancel call here:
https://cs.opensource.google/go/x/crypto/+/master:acme/acme_test.go;l=990;drc=9d1352758620574fd6fc23c31c59c4333b4b3fff

I'll mail a fix.

@bcmills bcmills added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jan 12, 2022
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/378074 mentions this issue: acme: in TestFetchCertCancel, do not reply before the cancellation propagates

owenthereal pushed a commit to owenthereal/upterm.crypto that referenced this issue Mar 5, 2022
@owenthereal
acme: in TestFetchCertCancel, do not reply before the cancellation pr…
d3c47a4 
…opagates

Fixes golang/go#44611

Change-Id: I81b3c3b7be25fe4e492695fa5935e70aa7b96c07
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/378074
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
@rsc rsc unassigned bcmills Jun 23, 2022
iamacarpet pushed a commit to affordablemobiles/xcrypto that referenced this issue Aug 2, 2022
@iamacarpet
acme: in TestFetchCertCancel, do not reply before the cancellation pr…
123c2e2 
…opagates

Fixes golang/go#44611

Change-Id: I81b3c3b7be25fe4e492695fa5935e70aa7b96c07
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/378074
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this issue Feb 16, 2023
acme: in TestFetchCertCancel, do not reply before the cancellation pr…
8adb7aa 
…opagates

Fixes golang/go#44611

Change-Id: I81b3c3b7be25fe4e492695fa5935e70aa7b96c07
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/378074
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
acme: in TestFetchCertCancel, do not reply before the cancellation pr…
e7be275 
…opagates

Fixes golang/go#44611

Change-Id: I81b3c3b7be25fe4e492695fa5935e70aa7b96c07
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/378074
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
4 participants
@dmitshur @bcmills @gopherbot @cherrymui