Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: literal completions broken with dot import #44589

Closed
muirdm opened this issue Feb 24, 2021 · 1 comment
Closed

x/tools/gopls: literal completions broken with dot import #44589

muirdm opened this issue Feb 24, 2021 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.6.10

Comments

@muirdm
Copy link

muirdm commented Feb 24, 2021 

package main

import (
	. "bytes"
)

func main() {
	var _ *Buffer = <> // completes to "&..Buffer{}"
}

"A" for effort.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 24, 2021
@gopherbot gopherbot added this to the Unreleased milestone Feb 24, 2021
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Feb 24, 2021
@muirdm muirdm mentioned this issue Mar 17, 2021
Closed
ShoshinNikita added a commit to ShoshinNikita/tools that referenced this issue Mar 17, 2021
@ShoshinNikita
internal/lsp/source: fix hover and completion with dot imports
ea82686 
Qualifier now returns empty package name for dot imports.

Fixes golang/go#44589
Fixes golang/go#45063
@ShoshinNikita ShoshinNikita mentioned this issue Mar 17, 2021
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/302589 mentions this issue: internal/lsp/source: fix hover and completion with dot imports

@golang golang locked and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.6.10
Development

Successfully merging a pull request may close this issue.

internal/lsp/source: fix hover and completion with dot imports ShoshinNikita/tools
3 participants
@stamblerre @gopherbot @muirdm