Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: can get stuck in a redirect loop with a weird module path #44534

Closed
mvdan opened this issue Feb 23, 2021 · 1 comment
Closed

x/pkgsite: can get stuck in a redirect loop with a weird module path #44534

mvdan opened this issue Feb 23, 2021 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite

Comments

@mvdan
Copy link
Member

mvdan commented Feb 23, 2021

Take https://github.com/ipld/go-codec-dagpb, and note that the module path is github.com/ipld/go-codec-dagpb/dagpb, which has an extra /dagpb. That was probably a mistake or a misunderstanding of some sort, but that's not the point of this issue.

The point of this issue is simple: if you navigate to https://pkg.go.dev/github.com/ipld/go-codec-dagpb/dagpb, it redirects forever, presumably because it is confused by the mismatch :)

I don't think this weird edge case is particularly important, but pkgsite should never enter into redirect cycles. A good way to detect these in general might be a good idea, with plenty of tests.

cc @julieqiu @jba

@mvdan mvdan added the pkgsite label Feb 23, 2021
@gopherbot gopherbot added this to the Unreleased milestone Feb 23, 2021
@julieqiu julieqiu added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 23, 2021
@julieqiu julieqiu self-assigned this Feb 23, 2021
@gopherbot
Copy link

Change https://golang.org/cl/295549 mentions this issue: internal/frontend: fix redirect loops

@golang golang locked and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Development

No branches or pull requests

3 participants