You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Take https://github.com/ipld/go-codec-dagpb, and note that the module path is github.com/ipld/go-codec-dagpb/dagpb, which has an extra /dagpb. That was probably a mistake or a misunderstanding of some sort, but that's not the point of this issue.
I don't think this weird edge case is particularly important, but pkgsite should never enter into redirect cycles. A good way to detect these in general might be a good idea, with plenty of tests.
Take https://github.com/ipld/go-codec-dagpb, and note that the module path is
github.com/ipld/go-codec-dagpb/dagpb
, which has an extra/dagpb
. That was probably a mistake or a misunderstanding of some sort, but that's not the point of this issue.The point of this issue is simple: if you navigate to https://pkg.go.dev/github.com/ipld/go-codec-dagpb/dagpb, it redirects forever, presumably because it is confused by the mismatch :)
I don't think this weird edge case is particularly important, but pkgsite should never enter into redirect cycles. A good way to detect these in general might be a good idea, with plenty of tests.
cc @julieqiu @jba
The text was updated successfully, but these errors were encountered: