go/types, types2: writeType does not invoke Qualifier when printing an unsafe.Pointer #44515
Labels
Milestone
Comments
|
This seems reasonable to me. Given that this logic predates https://golang.org/cl/11692 adding the Qualifier function, perhaps this was just an oversight. CC @griesemer |
|
Change https://golang.org/cl/295271 mentions this issue: |
|
Thanks for pointing this out; I think @findleyr is correct, this looks like an oversight. Fix is out. |
griesemer
changed the title
|
Change https://golang.org/cl/296289 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Feb 25, 2021
The go/types fix for golang/go#44515 changed the type string for unsafe.Pointer from a fixed "unsafe.Pointer" to a customizable package path followed by "Pointer" (the customization was in place for any other object already). The package path customization is done through a user-provider types.Qualifier function. If none is provided, the ordinary package path is used ("unsafe"). Guru provides a package-relative qualifier which leaves away the package path if an object is local to a package. As a result, unsafe.Pointer is printed as "Pointer" which breaks an existing test. Provide no qualifier function when printing a type from package unsafe instead (there's only unsafe.Pointer). Since no qualifier was used in the past, this Guru-specific change will also work when run using earlier Go versions. Fixes golang/go#44596. Updates golang/go#44515. Change-Id: I3c467e4ed09aa13deb50368fe98e42c723a6376b Reviewed-on: https://go-review.googlesource.com/c/tools/+/296289 Trust: Robert Griesemer <gri@golang.org> Run-TryBot: Robert Griesemer <gri@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Because
unsafe.Pointeris a*types.Basic, the type stringifier uses a special case to print the package name:As written, this does not allow a given Qualifier function to run and control how the package name is printed, which means that anything which wants to print something other than
"unsafe"must do so by also special casingunsafe.Pointer.Is there any reason not to use the Qualifier function in
writeTypewhen printingunsafe.Pointer? This would be a very quick change, but I wanted to make sure the current functionality isn't deliberate before opening a CL.The text was updated successfully, but these errors were encountered: