Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json.Marshal fails silently on structs with an interface-valued map field #445

Closed
rsaarelm opened this issue Dec 19, 2009 · 3 comments
Closed

Comments

@rsaarelm
Copy link
Contributor

Before filing a bug, please check whether it has been fixed since
the latest release: run "hg pull -u" and retry what you did to
reproduce the problem.  Thanks.

What steps will reproduce the problem?
1. Run the new json package unit test in the attached patch

What is the expected output? What do you see instead?

Marshal should report an error due to an interface value. Instead it
returns no error and truncates the output for the map value field at the
point where the invalid value occurs.

What is your $GOOS?  $GOARCH?

linux 386

Which revision are you using?  (hg identify)

84c2d8accf42+ tip

Please provide any additional information below.

Attachments:

  1. issue445.diff (656 bytes)
@rsc
Copy link
Contributor

rsc commented Dec 21, 2009

Comment 1:

Owner changed to r...@golang.org.

Status changed to HelpWanted.

@krasin
Copy link

krasin commented Dec 22, 2009

Comment 2:

Fix is under review: http://golang.org/cl/179125

@rsc
Copy link
Contributor

rsc commented Jan 6, 2010

Comment 3:

This issue was closed by revision e324e40.

Status changed to Fixed.

Merged into issue #-.

@rsaarelm rsaarelm added the fixed label Jan 6, 2010
@golang golang locked and limited conversation to collaborators Jun 24, 2016
@rsc rsc removed their assignment Jun 22, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants