Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: "internal compiler error: arg 1 does not dominate" with ssacheck on #44465

Closed
ALTree opened this issue Feb 20, 2021 · 3 comments
Closed

cmd/compile: "internal compiler error: arg 1 does not dominate" with ssacheck on #44465

ALTree opened this issue Feb 20, 2021 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.17

Comments

@ALTree
Copy link
Member

ALTree commented Feb 20, 2021 •
edited 

go version go1.15.8 linux/amd64

go version go1.16 linux/amd64

go version devel +d4b2638234 Sat Feb 20 03:54:50 2021 +0000 linux/amd64

package p

func f() {
	var b bool
	if b {
		b = true
	}
l:
	for !b {
		b = true
		goto l
	}
}

$ go tool compile -d=ssa/check/seed crash.go 
crash.go:5:2: internal compiler error: 'f': arg 1 of value v7 = Phi <mem> v1 v7 does not dominate, arg=v7 = Phi <mem> v1 v7
@ALTree ALTree added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 20, 2021
@ALTree ALTree added this to the Go1.17 milestone Feb 20, 2021
@randall77
Copy link
Contributor

This looks like a shortcircuit bug. @josharian this looks like it was introduced at CL 222923.

@josharian
Copy link
Contributor

@ALTree you always have the best CFGs. I’m AFK possibly until Monday but will fix ASAP. Likely to be a very simple, targeted fix.

@gopherbot
Copy link

Change https://golang.org/cl/295130 mentions this issue: cmd/compile: reject some rare looping CFGs in shortcircuit

@golang golang locked and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
4 participants
@josharian @ALTree @randall77 @gopherbot