-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: ICE on deferred call to syscall.LazyDLL.Call [1.16 backport] #44464
Comments
Change https://golang.org/cl/296489 mentions this issue: |
Approved. This is a serious issue. |
What's the time frame like for 1.16.1? I'm wondering how much time we have for finding a revised fix for #44415 and preparing a backport CL. |
The point releases are tentatively scheduled for the middle of the first week in March 2021. |
Okay, great, we should definitely have a fix for this by then. |
Change https://golang.org/cl/296769 mentions this issue: |
…r arguments with call method in go/defer In CL 253457, we did the same fix for direct function calls. But for method calls, the receiver argument also need to be passed through the wrapper function, which we are not doing so the compiler crashes with the code in #44415. It will be nicer if we can rewrite OCALLMETHOD to normal OCALLFUNC, but that will be for future CL. The passing receiver argument to wrapper function is easier for backporting to go1.16 branch. Fixes #44464 Change-Id: I03607a64429042c6066ce673931db9769deb3124 Reviewed-on: https://go-review.googlesource.com/c/go/+/296490 Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com> Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-on: https://go-review.googlesource.com/c/go/+/296769 Trust: Bryan C. Mills <bcmills@google.com>
Closed by merging ca9cd62 to release-branch.go1.16. |
@ianlancetaylor requested issue #44415 (fixed by 23943a6 for Go 1.17) to be considered for backport to the next 1.16 minor release.
The text was updated successfully, but these errors were encountered: