Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/analysis, syscall: ptrace redeclared in this block [1.16 backport] #44462

Closed
gopherbot opened this issue Feb 20, 2021 · 3 comments
Closed

x/tools/go/analysis, syscall: ptrace redeclared in this block [1.16 backport] #44462

gopherbot opened this issue Feb 20, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Go1.16.2

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #44459 to be considered for backport to the next 1.16 minor release.

@gopherbot Please open backport to 1.16.

The 1.16 release can't be analyzed by tools built with earlier versions of Go, because those earlier releases don't recognize that "ios" is now a valid GOOS value. The fix is to use an explicit build tag. We should backport that fix to the 1.16 release branch.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 20, 2021
@gopherbot gopherbot mentioned this issue Feb 20, 2021
Closed
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Feb 20, 2021
@gopherbot gopherbot modified the milestones: Unreleased, Go1.16.1 Feb 20, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/294635 mentions this issue: [release-branch.go1.16] syscall: add explicit ios build tag

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Feb 25, 2021
@cagedmantis
Copy link
Contributor

Approved. This is a serious issue.

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 25, 2021
@gopherbot
Copy link
Author

Closed by merging b7e0eb4 to release-branch.go1.16.

gopherbot pushed a commit that referenced this issue Feb 25, 2021
@ianlancetaylor
[release-branch.go1.16] syscall: add explicit ios build tag
b7e0eb4 
This permits analysis of the syscall package by tools built with
older versions of Go that do not recognize ios as a GOOS.

For #44459
Fixes #44462

Change-Id: I79cec2ffe0dbcbc2dc45a385e556dc9e62033125
Reviewed-on: https://go-review.googlesource.com/c/go/+/294634
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
(cherry picked from commit 03d36d8)
Reviewed-on: https://go-review.googlesource.com/c/go/+/294635
Reviewed-by: Cherry Zhang <cherryyz@google.com>
@toothrot toothrot modified the milestones: Go1.16.1, Go1.16.2 Mar 10, 2021
@golang golang locked and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Go1.16.2
Development

No branches or pull requests
3 participants
@toothrot @cagedmantis @gopherbot