Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: "How to Write Go Code" manual - top-level go test does not find tests #44460

Closed
shamrin opened this issue Feb 20, 2021 · 2 comments
Closed

x/website: "How to Write Go Code" manual - top-level go test does not find tests #44460

shamrin opened this issue Feb 20, 2021 · 2 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@shamrin
Copy link

shamrin commented Feb 20, 2021

What version of Go are you using (go version)?

$ go version
go version go1.16 darwin/amd64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/user/Library/Caches/go-build"
GOENV="/Users/user/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/user/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/user/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.16"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/user/src/swanbase/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/n1/gz5vlp814xsdfq0ncffzgqcc0000gq/T/go-build3415797913=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

I followed "How to Write Go Code" manual, "Testing" section. The manual says:

Add a test to the morestrings package by creating the file $HOME/hello/morestrings/reverse_test.go containing the following Go code.
...
Then run the test with go test:

$ go test
PASS
ok  	example.com/user/morestrings 0.165s
$

However, go test doesn't work for the top folder:

$ go test
?       example.com/user/hello  [no test files]
$ pwd
/Users/user/src/hello
$ tree
.
├── go.mod
├── go.sum
├── hello
├── hello.go
└── morestrings
    ├── reverse.go
    └── reverse_test.go

What did you expect to see?

I expected go test to find tests in morestrings automatically. Alternatively, the manual should suggest one of:

  • go test ./morestrings
  • go test ./...
  • cd morestrings; go test
@gopherbot gopherbot added this to the Unreleased milestone Feb 20, 2021
@seankhliao seankhliao added Documentation NeedsFix The path to resolution is known, but the work has not been done. labels Feb 20, 2021
@180909 180909 mentioned this issue Aug 31, 2021
Closed
@gopherbot
Copy link

Change https://golang.org/cl/346130 mentions this issue: _content/doc: fix go test command line command

@gopherbot
Copy link

Change https://golang.org/cl/350250 mentions this issue: _content/code.html: clarify that 'go test' runs in the source directory

@golang golang locked and limited conversation to collaborators Sep 16, 2022
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
_content/code.html: clarify that 'go test' runs in the source directory
7aa5b9c 
Fixes golang/go#44460.

Change-Id: I8192bffa691015b1cb9a3cfa78958850891a67e5
Reviewed-on: https://go-review.googlesource.com/c/website/+/350250
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

_content/doc: fix go test command line command 180909/website
3 participants
@shamrin @gopherbot @seankhliao