Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: possible panic in getFullPR #44438

Closed
dmitshur opened this issue Feb 19, 2021 · 1 comment
Closed

x/build/cmd/gerritbot: possible panic in getFullPR #44438

dmitshur opened this issue Feb 19, 2021 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

Observed this panic from 43 days ago:

2021/02/04 06:15:49 Retrieving PR golang/blog#34 from GitHub using Etag "W/\"8a7ebf3c8163c89f842d22ec8a135ec89f9af0061f034bbd6a13ad716abff05b\"" ...
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xa67639]

goroutine 154 [running]:
main.(*bot).getFullPR(0xc000156140, 0xd79360, 0xc0000b4000, 0xc04db30a80, 0x6, 0xc04db30a88, 0x4, 0x22, 0xb, 0x1c, ...)
	/go/src/golang.org/x/build/cmd/gerritbot/gerritbot.go:836 +0x4c9
main.(*bot).checkPullRequests.func2.1(0xc0364af2c0, 0x0, 0x0)
	/go/src/golang.org/x/build/cmd/gerritbot/gerritbot.go:355 +0xce
golang.org/x/build/maintner.(*GitHubRepo).ForeachIssue(0xc07505c240, 0xc000385cb0, 0xc04db30a88, 0x4)
	/go/src/golang.org/x/build/maintner/github.go:160 +0x24b
main.(*bot).checkPullRequests.func2(0xc07505c240, 0xc071df2660, 0xc000321d80)
	/go/src/golang.org/x/build/cmd/gerritbot/gerritbot.go:337 +0xc6
golang.org/x/build/maintner.(*GitHub).ForeachRepo(0xc021995960, 0xc000385ea8, 0xc08b62b680, 0x12)
	/go/src/golang.org/x/build/maintner/github.go:76 +0x2db
main.(*bot).checkPullRequests(0xc000156140)
	/go/src/golang.org/x/build/cmd/gerritbot/gerritbot.go:332 +0x21d
main.(*bot).corpusUpdateLoop(0xc000156140, 0xd79360, 0xc0000b4000)
	/go/src/golang.org/x/build/cmd/gerritbot/gerritbot.go:284 +0x6f
created by main.main
	/go/src/golang.org/x/build/cmd/gerritbot/gerritbot.go:81 +0x2fc

Relevant line on latest master version is gerritbot.go:834.
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Feb 19, 2021
@dmitshur dmitshur added this to the Unreleased milestone Feb 19, 2021
@dmitshur dmitshur self-assigned this Feb 19, 2021
@gopherbot
Copy link

Change https://golang.org/cl/294412 mentions this issue: cmd/gerritbot: check for nil *github.Response before accessing

@dmitshur dmitshur added this to In Progress in Go Release Team Feb 23, 2021
Go Release Team automation moved this from In Progress to Done Feb 23, 2021
@golang golang locked and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot