-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: Compiler regression in Go 1.16 - internal compiler error: child dcl collision on symbol [1.16 backport] #44433
Labels
Milestone
Comments
Change https://golang.org/cl/294789 mentions this issue: |
Approved. This is a serious issue. |
Closed by merging 18e5d75 to release-branch.go1.16. |
gopherbot
pushed a commit
that referenced
this issue
Mar 1, 2021
…obfuscated code DWARF generation uses variable source positions (file/line/col) as a way to uniquely identify locals and parameters, as part of the process of matching up post-optimization variables with the corresponding pre-optimization versions (since the DWARF needs to be in terms of the original source constructs). This strategy can run into problems when compiling obfuscated or machine-generated code, where you can in some circumstances wind up with two local variables that appear to have the same name, file, line, and column. This patch changes DWARF generation to skip over such duplicates as opposed to issuing a fatal error (if an obfuscation tool is in use, it is unlikely that a human being will be able to make much sense of DWARF info in any case). Fixes #44433. Change-Id: I198022d184701aa9ec3dce42c005d29b72d2e321 Reviewed-on: https://go-review.googlesource.com/c/go/+/294289 TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Jeremy Faller <jeremy@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> Trust: Than McIntosh <thanm@google.com> Run-TryBot: Than McIntosh <thanm@google.com> (cherry picked from commit e78e04c) Reviewed-on: https://go-review.googlesource.com/c/go/+/294789
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
@thanm requested issue #44378 to be considered for backport to the next 1.16 minor release.
The text was updated successfully, but these errors were encountered: