Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/cgo: cannot build with -Wsign-compare [1.16 backport] #44346

Closed
gopherbot opened this issue Feb 17, 2021 · 3 comments
Closed

runtime/cgo: cannot build with -Wsign-compare [1.16 backport] #44346

gopherbot opened this issue Feb 17, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.16.2

Comments

@gopherbot
Copy link

gopherbot commented Feb 17, 2021 •
edited by dmitshur

@ianlancetaylor requested issue #44340 (fixed in 07ef313 for Go 1.17) to be considered for backport to the next 1.16 minor release.

@gopherbot Please open backport to 1.16.

This problem makes it hard to build 1.16 programs that use cgo if you want to use -Wsign-compare in CGO_CFLAGS (to check your own C code). The CL fixes the problem.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 17, 2021
@gopherbot gopherbot mentioned this issue Feb 17, 2021
Closed
@gopherbot
Copy link
Author

Change https://golang.org/cl/293411 mentions this issue: [release-branch.go1.16] runtime/cgo: add cast in C code to avoid C compiler warning

gopherbot pushed a commit that referenced this issue Feb 18, 2021
@ianlancetaylor
[release-branch.go1.16] runtime/cgo: add cast in C code to avoid C co…
1a7e9af 
…mpiler warning

For #44340
Fixes #44346

Change-Id: Id80dd1f44a988b653933732afcc8e49a826affc4
Reviewed-on: https://go-review.googlesource.com/c/go/+/293209
Reviewed-by: Andrew G. Morgan <agm@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 07ef313)
Reviewed-on: https://go-review.googlesource.com/c/go/+/293411
TryBot-Result: Go Bot <gobot@golang.org>
@gopherbot gopherbot added this to the Go1.16.1 milestone Feb 19, 2021
@gopherbot
Copy link
Author

Closed by merging 1a7e9af to release-branch.go1.16.

@dmitshur dmitshur mentioned this issue Feb 19, 2021
Closed
@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Feb 25, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 25, 2021
@toothrot
Copy link
Contributor

Approved. This is a serious issue with no workaround.

We actually had approved it before this was submitted according to my notes, but I failed to comment on the issue.

@toothrot toothrot modified the milestones: Go1.16.1, Go1.16.2 Mar 10, 2021
@golang golang locked and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.16.2
Development

No branches or pull requests
2 participants
@toothrot @gopherbot