Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http/httputil: DumpRequestOut triggers clienttrace Get/GotConn #44281

Open
davidbrink opened this issue Feb 16, 2021 · 0 comments
Open

net/http/httputil: DumpRequestOut triggers clienttrace Get/GotConn #44281

davidbrink opened this issue Feb 16, 2021 · 0 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unplanned

Comments

@davidbrink
Copy link

What version of Go are you using (go version)?

$ go version
go version go1.15.8 darwin/amd64

Does this issue reproduce with the latest release?

1.15.8 is the latest release.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/dbrink/Library/Caches/go-build"
GOENV="/Users/dbrink/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/dbrink/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/dbrink/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.15.8/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.15.8/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/gb/vk5wy1jd4msc49d1vpdwf_j80015jz/T/go-build050741674=/tmp/go-build -gno-record-gcc-switches -fno-common"
GOROOT/bin/go version: go version go1.15.8 darwin/amd64
GOROOT/bin/go tool compile -V: compile version go1.15.8
uname -v: Darwin Kernel Version 19.6.0: Tue Nov 10 00:10:30 PST 2020; root:xnu-6153.141.10~1/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.15.7
BuildVersion:	19H114
lldb --version: lldb-1200.0.44.2
Apple Swift version 5.3.2 (swiftlang-1200.0.45 clang-1200.0.32.28)
gdb --version: GNU gdb (GDB) 9.2

What did you do?

https://play.golang.org/p/_AAQ-0N9QI-

What did you expect to see?

GET / HTTP/1.1
Host: www.foo.com
User-Agent: Go-http-client/1.1
Content-Length: 5
Accept-Encoding: gzip

hello

What did you see instead?

GetConn: www.foo.com:80
GotConn: {0xc00000e360 false false 0s}
GET / HTTP/1.1
Host: www.foo.com
User-Agent: Go-http-client/1.1
Content-Length: 5
Accept-Encoding: gzip

hello
@seankhliao seankhliao added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 16, 2021
@seankhliao seankhliao changed the title httputil.DumpRequestOut has unwanted side effects net/http/httputil DumpRequestOut triggers clienttrace Get/GotConn Feb 16, 2021
@seankhliao seankhliao changed the title net/http/httputil DumpRequestOut triggers clienttrace Get/GotConn net/http/httputil: DumpRequestOut triggers clienttrace Get/GotConn Feb 16, 2021
@seankhliao seankhliao added this to the Unplanned milestone Aug 20, 2022
@vadmeste vadmeste mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
2 participants
@seankhliao @davidbrink