Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: go.mod for cmd is not the right go.mod #44258

Open
hyangah opened this issue Feb 14, 2021 · 1 comment
Open

x/pkgsite: go.mod for cmd is not the right go.mod #44258

hyangah opened this issue Feb 14, 2021 · 1 comment
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. pkgsite
Milestone
pkgsite/unplanned

Comments

@hyangah
Copy link
Contributor

hyangah commented Feb 14, 2021

https://pkg.go.dev/cmd is pointing to the src/go.mod
https://go.googlesource.com/go/+/go1.15.8/src/go.mod

It needs to be src/cmd/go.mod
https://go.googlesource.com/go/+/go1.15.8/src/cmd/go.mod
@gopherbot gopherbot added this to the Unreleased milestone Feb 14, 2021
@jba jba added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Feb 15, 2021
@jba jba modified the milestones: Unreleased, pkgsite/unplanned Feb 15, 2021
@jba
Copy link
Contributor

jba commented Feb 15, 2021

This is a consequence of pkgsite treating everything under src as a single module, regardless of internal module divisions.
@julieqiu perhaps we should revisit that decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
3 participants
@hyangah @gopherbot @jba