Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: merge module doc changes as part of Go 1.16 release #44249

Closed
ALTree opened this issue Feb 13, 2021 · 5 comments
Closed

x/website: merge module doc changes as part of Go 1.16 release #44249

ALTree opened this issue Feb 13, 2021 · 5 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@ALTree
Copy link
Member

ALTree commented Feb 13, 2021

1.16 introduces a retract directive. The new directive is not mentioned in the Go Modules Reference. The CL adding the doc will need to be merged before the 1.16 release (currently has a merge conflict).

In 1.16, go install will accepts arguments with version suffixes (go install pkg@version). The CL adding the relevant doc will need to be merged before the 1.16 release (currently has a merge conflict, and unresolved comments).

Filing an issue just to be sure this is on someone's radar.

cc @dmitshur @bcmills

@ALTree ALTree added Documentation NeedsFix The path to resolution is known, but the work has not been done. labels Feb 13, 2021
@ALTree ALTree added this to the Go1.16 milestone Feb 13, 2021
@dmitshur
Copy link
Contributor

Thanks. If I understand correctly, @jayconrod is planning to submit that CL stack as part of the Go 1.16 release, and we will coordinate the timing as needed. The merge conflict is because it’s a CL in the middle of a stack, I don’t think it’s a problem. The comments will need to be addressed.

Also CC @rsc, @stevetraut as FYI.

@ALTree
Copy link
Member Author

ALTree commented Feb 13, 2021

Great! Thanks for confirming. I was trying to find documentation for the new retract directive and I was somewhat surprised I couldn't find any in tip.golang.org. But I guess with the new x/website setup website changes will get committed at the very last moment from now on(?)...

@dmitshur
Copy link
Contributor

dmitshur commented Feb 13, 2021

changes will get committed at the very last moment from now on(?)

For Go 1.16, yes, but that isn't a great experience and we'll look about improving it in the future (perhaps with a branch, or something else). CL 291693 goes a long way to reduce the tight coupling between the main repo and x/website, which will give us good options to work with.

@dmitshur dmitshur changed the title doc: merge module doc changes before 1.16 release x/website: merge module doc changes as part of Go 1.16 release Feb 13, 2021
@dmitshur
Copy link
Contributor

I left a comment on CL 284812, the first unmerged CL in that stack, noting that it's safe to start landing it now. CC @jayconrod.

@toothrot toothrot modified the milestones: Go1.16, Go1.17 Feb 16, 2021
@ALTree
Copy link
Member Author

ALTree commented Feb 19, 2021

Fixed by merging the aforementioned CL stack.

@ALTree ALTree closed this as completed Feb 19, 2021
@golang golang locked and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

5 participants