Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/cgo: wrong comment about Linux at *_freebsd_*.c #44248

Closed
hajimehoshi opened this issue Feb 13, 2021 · 1 comment
Closed

runtime/cgo: wrong comment about Linux at *_freebsd_*.c #44248

hajimehoshi opened this issue Feb 13, 2021 · 1 comment
Labels
FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD
Milestone
Backlog

Comments

@hajimehoshi
Copy link
Member

go/src/runtime/cgo/gcc_freebsd_arm.c

Lines 53 to 55 in 0e85fd7

// Not sure why the memset is necessary here,
// but without it, we get a bogus stack size
// out of pthread_attr_getstacksize. C'est la Linux.

I'm not sure whether this memset makes sense for FreeBSD or not (I guess not)
@hajimehoshi hajimehoshi added OS-FreeBSD NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 13, 2021
@ianlancetaylor ianlancetaylor added this to the Backlog milestone Feb 13, 2021
@gopherbot
Copy link

Change https://go.dev/cl/393617 mentions this issue: runtime/cgo: remove memset in _cgo_sys_thread_start on freebsd/arm

@golang golang locked and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@hajimehoshi @ianlancetaylor @gopherbot