Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: possible panic in handleLogs #44244

Closed
dmitshur opened this issue Feb 12, 2021 · 1 comment
Closed

x/build/cmd/coordinator: possible panic in handleLogs #44244

dmitshur opened this issue Feb 12, 2021 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Feb 12, 2021 •
edited

Observed the following panic:

panic: net/http: CloseNotify called after ServeHTTP finished

goroutine 121398777 [running]:
net/http.(*response).CloseNotify(0xc0122242a0, 0x1c40100)
	/usr/local/go/src/net/http/server.go:1996 +0x5e
main.handleLogs.func1(0x1c40100, 0xc0122242a0, 0x1c30620, 0xc0132ce080)
	/go/src/golang.org/x/build/cmd/coordinator/coordinator.go:813 +0x55
created by main.handleLogs
	/go/src/golang.org/x/build/cmd/coordinator/coordinator.go:812 +0x5ff

It looks like a race. The goroutine may start after handleLogs finishes.

CC @golang/release.
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 12, 2021
@dmitshur dmitshur added this to the Unreleased milestone Feb 12, 2021
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 12, 2021
@dmitshur dmitshur changed the title x/build/cmd/coordinator: panic in handleLogs x/build/cmd/coordinator: possible panic in handleLogs Feb 12, 2021
@gopherbot
Copy link

Change https://golang.org/cl/291769 mentions this issue: cmd/coordinator: use Request.Context in handleLogs

@golang golang locked and limited conversation to collaborators Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot