Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/release: gopher should not hide at night #44239

Closed
dmitshur opened this issue Feb 12, 2021 · 1 comment
Closed

x/build/cmd/release: gopher should not hide at night #44239

dmitshur opened this issue Feb 12, 2021 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin UX Issues that involve UXD/UXR input
Milestone
Go1.16

Comments

@dmitshur
Copy link
Contributor

When running the macOS installer, the friendly gopher disappears when macOS Dark appearance is used:

gopher.hiding.at.night.mov

The Distribution XML specifies a background parameter pointing to "bg.png". It seems this parameter is used only in Light appearance, and a background-darkAqua parameter needs to specify the background for Dark appearance. After being added, the gopher remains visible at all times.

I'll send a fix.
@dmitshur dmitshur added OS-Darwin NeedsFix The path to resolution is known, but the work has not been done. UX Issues that involve UXD/UXR input labels Feb 12, 2021
@dmitshur dmitshur added this to the Go1.16 milestone Feb 12, 2021
@dmitshur dmitshur self-assigned this Feb 12, 2021
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 12, 2021
@dmitshur
Copy link
Contributor Author

This has been fixed and will included in future Go releases.

@dmitshur dmitshur mentioned this issue Jan 21, 2022
Closed
@golang golang locked and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin UX Issues that involve UXD/UXR input
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot