Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/talks: deploy instructions in README are non-functional because go.mod isn't updated after rsync step #44164

Closed
dmitshur opened this issue Feb 8, 2021 · 1 comment
Closed

x/talks: deploy instructions in README are non-functional because go.mod isn't updated after rsync step #44164

dmitshur opened this issue Feb 8, 2021 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Feb 8, 2021

We found out during a deploy attempt for #43455 that following the deploy instructions in the README results in an error from cloud build, preventing the deploy from succeeding:

Error message: build golang.org/x/talks: cannot find module for path golang.org/x/tools/godoc/static

This happens because the go.mod file isn't updated to require the golang.org/x/tools module after rsync copies cmd/present from x/tools. It can be resolved by running go mod tidy or go get -d between the rsync and gcloud deploy steps.

I'll send a CL to update the README and restore deployment functionality.

CC @golang/release, @katiehockman.
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 8, 2021
@dmitshur dmitshur added this to the Unreleased milestone Feb 8, 2021
@dmitshur dmitshur self-assigned this Feb 8, 2021
@gopherbot
Copy link

Change https://golang.org/cl/290192 mentions this issue: README: update deployment instructions for module mode

@dmitshur dmitshur mentioned this issue Feb 8, 2021
Closed
@golang golang locked and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot