Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: compiler can fault in low memory conditions #4415

Closed
bradfitz opened this issue Nov 20, 2012 · 6 comments
Closed

cmd/compile: compiler can fault in low memory conditions #4415

bradfitz opened this issue Nov 20, 2012 · 6 comments
Labels
FrozenDueToAge
Milestone
Unplanned

Comments

@bradfitz
Copy link
Contributor 

OpenBSD compiler crash,

From
http://build.golang.org/log/081228dc3bc44ae1f6911395558c17ae16176b61

internal compiler error: fault
@4a6f656c
Copy link
Contributor

Comment 1:

It would appear that the memory usage has increased slightly of late and that has been
enough to result in occasional malloc failures during compilation (the host only
has 256MB of RAM and had 512MB of swap - I've since bumped this up). There are several
instances where gc does not check the return from malloc, so instead of resulting in an
"out of memory" failure, we've ended up faulting. There are also additional unchecked
mallocs throughout src/cmd and src/libmach.

Labels changed: removed os-openbsd.

@minux
Copy link
Member

minux commented Nov 25, 2012

Comment 2:

i've audited all commands and libraries besides cmd/gc and cmd/?g.
https://golang.org/cl/6856080/

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 4:

Labels changed: added priority-someday.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 5:

Labels changed: added repo-main.

@rsc
Copy link
Contributor

rsc commented Mar 3, 2014

Comment 6:

Adding Release=None to all Priority=Someday bugs.

Labels changed: added release-none.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title cmd/gc: compiler can fault in low memory conditions cmd/compile: compiler can fault in low memory conditions Jun 8, 2015
@mdempsky
Copy link
Member

mdempsky commented Nov 1, 2020

I think this is no longer an issue since cmd/compile was ported to Go. The Go runtime is now responsible for reporting when memory allocation fails.

@mdempsky mdempsky closed this as completed Nov 1, 2020
@mdempsky mdempsky mentioned this issue Nov 1, 2020
Closed
@golang golang locked and limited conversation to collaborators Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
6 participants
@bradfitz @mdempsky @rsc @minux @4a6f656c @gopherbot