Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: add dependency suggested fix broken with experimentalWorkspaceModule #44132

Closed
stamblerre opened this issue Feb 6, 2021 · 1 comment
Closed

x/tools/gopls: add dependency suggested fix broken with experimentalWorkspaceModule #44132

stamblerre opened this issue Feb 6, 2021 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.6.6

Comments

@stamblerre
Copy link
Contributor

Similar to the go mod tidy and update go.sum quick fixes, the add dependency quick fix does not work in experimental workspace module mode. The issue is again that we don't associate the fix with the correct module, which can lead to unpredictable results.
@stamblerre stamblerre added this to the gopls/v0.6.6 milestone Feb 6, 2021
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 6, 2021
@gopherbot
Copy link

Change https://golang.org/cl/291192 mentions this issue: internal/lsp: refactor go command error handling

@golang golang locked and limited conversation to collaborators Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.6.6
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot