Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: jump to dialog is obscured on safari & firefox #44077

Closed
jamalc opened this issue Feb 2, 2021 · 3 comments
Closed

x/pkgsite: jump to dialog is obscured on safari & firefox #44077

jamalc opened this issue Feb 2, 2021 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Milestone
pkgsite/frontend

Comments

@jamalc
Copy link

jamalc commented Feb 2, 2021 •
edited

After pressing the f key to open the "jump to" dialog the backdrop appears but the form is hidden in Firefox and Safari browsers. This issue does not affect Chrome.
@jamalc jamalc added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite labels Feb 2, 2021
@jamalc jamalc added this to the pkgsite/frontend milestone Feb 2, 2021
@jamalc jamalc self-assigned this Feb 2, 2021
@jamalc jamalc changed the title x/pkgsite: jump to dialog doesn't is obscured on safari & firefox x/pkgsite: jump to dialog is obscured on safari & firefox Feb 5, 2021
@xybydy
Copy link

xybydy commented Feb 7, 2021

looking for this issue. I have this issue on safari 14.0.1

@jamalc jamalc mentioned this issue Feb 8, 2021
Closed
@gopherbot
Copy link

Change https://golang.org/cl/290191 mentions this issue: content/static: fix jump to dialog positioning

@eliben
Copy link
Member

eliben commented Feb 12, 2021

Thanks for the fix, @jamalc -- the issue is now resolve for me on Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:85.0) Gecko/20100101 Firefox/85.0

@golang golang locked and limited conversation to collaborators Feb 12, 2022
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
@rsc rsc unassigned jamalc Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
5 participants
@eliben @xybydy @hyangah @gopherbot @jamalc