Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: DB has empty documentation rows #44048

Closed
jba opened this issue Feb 1, 2021 · 2 comments
Closed

x/pkgsite: DB has empty documentation rows #44048

jba opened this issue Feb 1, 2021 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone
pkgsite/unplanned

Comments

@jba
Copy link
Contributor

jba commented Feb 1, 2021

The database has many rows in the documentation table with empty GOOS/GOARCH columns. That shouldn't happen.
@jba jba added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite labels Feb 1, 2021
@jba jba added this to the pkgsite/unplanned milestone Feb 1, 2021
@jba jba self-assigned this Feb 1, 2021
@gopherbot
Copy link

Change https://golang.org/cl/288512 mentions this issue: internal/postgres: fail on attempt to insert doc with empty GOOS/GOARCH

gopherbot pushed a commit to golang/pkgsite that referenced this issue Feb 1, 2021
@jba
internal/postgres: fail on attempt to insert doc with empty GOOS/GOARCH
0675147 
We should never insert documentation with an empty GOOS/GOARCH pair.

For golang/go#44048

Change-Id: Ie4ccd881bb9441f523bada08e5ee8cf30f68b8f3
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/288512
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
@jba
Copy link
Contributor Author

jba commented Feb 1, 2021

It's unclear why these rows were inserted, but I've deleted them, and re-fetching some of the affected modules shows that the current worker isn't re-inserting blank rows. To be sure I made it an error to do so.

Closing until the problem recurs.

@jba jba closed this as completed Feb 1, 2021
@golang golang locked and limited conversation to collaborators Feb 1, 2022
@rsc rsc unassigned jba Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
2 participants
@gopherbot @jba