New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/website: https://golang.org featured video is unavailable https://youtu.be/cQ7STILAS0M #44037
Comments
Thanks for reporting this. It appears that that video is actually just the same Pike talk of another video (Simplicity is Complicated" talk from dotGo 2015) that is working correctly, so in golang/website@7323790 the link to cQ7STILAS0M was replaced with a link to the latter video. Looking at the relevant code, it seems the video that is now broken is actually not in the list of the ones that are choosen at random; but the broken video is still used as a placeholder in the html, so if you browse golang.org with javascript disabled, the script that replaces the placeholder video with one of the working videos doesn't run, and you get the static placeholder, which unfortunately now points to a dead video. I cannot get the broken video by refreshing the page, but if I disable javascript I indeed get that one. Do you have javascript disabled? In any case the default video that is served when the script doesn't run should be replaced with a link to a working video. |
Hello @ALTree, I do not have JS disabled, it just appears unavailable. I tried to refresh (CTRL+R) a couple of times, and some featured videos were available, but at some point the unavailable one appeared too. |
Interesting, I don't see how could you be served with the broken link looking at the code (it's not in the list of the videos), but I don't really know javascript so I may be missing something. cc @dmitshur |
It seems there is some sort of concurrency bug on Chrome only (I can repro it sporadically). I cannot reproduce with Firefox. Google Chrome version used: Version 88.0.4324.104 (Official Build) (64-bit) on Windows 10. |
I could repro the issue on a MacBook Pro with Chrome. |
Oh... so maybe a race between the javascript code substituting the video, and the static value being shown (which points to a video it shouldn't be shown). |
Change https://golang.org/cl/288692 mentions this issue: |
Fix the link for the placeholder video like CL 203825 did for the runtime selected one. Fixes golang/go#44037 Change-Id: Ic8b397c2c69f94d8a35e800515825380d06eaa4c Reviewed-on: https://go-review.googlesource.com/c/website/+/288692 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Alexander Rakoczy <alex@golang.org> Trust: Alexander Rakoczy <alex@golang.org> Trust: Carlos Amedee <carlos@golang.org>
The featured video from https://golang.org (bottom-left of the page) is unavailable. The youtube link is https://www.youtube.com/watch?v=cQ7STILAS0M.
The text was updated successfully, but these errors were encountered: