Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: Use HTML <details> element instead of Javascript #44000

Closed
ghost opened this issue Jan 30, 2021 · 9 comments
Closed

x/website: Use HTML <details> element instead of Javascript #44000

ghost opened this issue Jan 30, 2021 · 9 comments
Labels
FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@ghost
Copy link

ghost commented Jan 30, 2021

No description provided.

@gopherbot gopherbot added this to the Unreleased milestone Jan 30, 2021
@mdlayher
Copy link
Member

What exactly are you asking for? Can you clarify?

@mdlayher mdlayher added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jan 30, 2021
@ghost
Copy link
Author

ghost commented Jan 30, 2021

There are those widgets which can be opened and closed like example codes in pkg documentation. It would be nice if those are done using HTML details element instead of custom widget via Javascript thus making the webpage more useable without Javascript.

Another thing can be done is to make those example codes visible when Javascript isn't available.

@seankhliao

This comment has been minimized.

@ghost

This comment has been minimized.

@seankhliao

This comment has been minimized.

@seankhliao
Copy link
Member

Oh, I see on golang.org ex https://golang.org/pkg/encoding/json/#example_Decoder

@ghost
Copy link
Author

ghost commented Feb 1, 2021

@mdlayher Any more information?

@mdlayher
Copy link
Member

mdlayher commented Feb 1, 2021

I know nothing about modern frontend development and just asked for clarifying details for others who might.

@seankhliao seankhliao added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Feb 2, 2021
@seankhliao
Copy link
Member

Seems no longer relevant and pkgsite uses details

@golang golang locked and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants