Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: anchor link heading obscured by top banner in Safari #43999

Closed
myitcv opened this issue Jan 29, 2021 · 2 comments
Closed

x/pkgsite: anchor link heading obscured by top banner in Safari #43999

myitcv opened this issue Jan 29, 2021 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone
pkgsite/unplanned

Comments

@myitcv
Copy link
Member

myitcv commented Jan 29, 2021

What is the URL of the page with the issue?

https://pkg.go.dev/crypto@go1.15.6#PublicKey

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.1.2 Safari/605.1.15

Screenshot

Screen Shot 2021-01-29 at 20 11 32

What did you do?

Visited the above link using Safari

What did you expect to see?

The heading in the anchor link, per Chrome:

Screen Shot 2021-01-29 at 20 12 32

What did you see instead?

The heading obscured by the top banner:

Screen Shot 2021-01-29 at 20 11 32

cc @mpvl
@myitcv myitcv added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite labels Jan 29, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jan 29, 2021
@jamalc
Copy link

jamalc commented Jan 29, 2021

This is a known issue with WebKit based browsers. The WebKit team has released a fix and it is available in the WebKit Nightly Build. I'd prefer to wait for the next Safari release over making a Safari specific fix for this feature. We can leave this open for tracking purposes.

@jba jba modified the milestones: Unreleased, pkgsite/unplanned Jan 29, 2021
@jamalc jamalc mentioned this issue Apr 2, 2021
Closed
@jamalc
Copy link

jamalc commented May 6, 2021

This is fixed in the latest version of Safari.

@jamalc jamalc closed this as completed May 6, 2021
@golang golang locked and limited conversation to collaborators May 6, 2022
@rsc rsc unassigned jamalc Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
4 participants
@myitcv @gopherbot @jamalc @jba