Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embed: outdated sentences in documentation #43978

Closed
gazerro opened this issue Jan 28, 2021 · 2 comments
Closed

embed: outdated sentences in documentation #43978

gazerro opened this issue Jan 28, 2021 · 2 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.16

Comments

@gazerro
Copy link
Contributor

gazerro commented Jan 28, 2021

The documentation of the new embed package says:

The variable must be of type string, []byte, or FS exactly. Named types or type aliases
derived from those types are not allowed.

but the change https://golang.org/cl/282715 removed these limitations.

Similarly, it [the //go:embed directive] can be used with both global and function-local variables,
depending on what is more convenient in context.

but the change https://golang.org/cl/282714 removed support for vars embedded inside functions.
@ianlancetaylor
Copy link
Contributor

Thanks for pointing that out.

@ianlancetaylor ianlancetaylor added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Jan 29, 2021
@ianlancetaylor ianlancetaylor added this to the Go1.16 milestone Jan 29, 2021
@gopherbot
Copy link

Change https://golang.org/cl/288072 mentions this issue: embed: update docs for proposal tweaks

@golang golang locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
4 participants
@gazerro @ianlancetaylor @gopherbot and others