New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
archive/zip: CL 6811080 broke the ability to read a zip file #4393
Labels
Milestone
Comments
That zip file contains 13 bytes of extra data, the first 4 bytes, and the following 5 bytes are consumed, leaving 4 bytes unconsumed. This was my fault, I wrote the logic assuming that you need _more_ than 4 bytes of extra data, but in this case there is a tag with a 0 length. zip: tag 30805 size 0 What program created that zip file? Can you possibly recreate the core.zip file containing only one file, so it can be used as a test file ? Owner changed to @davecheney. Status changed to Accepted. |
http://golang.org/cl/6854058 Labels changed: added priority-soon, removed priority-triage. |
Yes, sorry, the panic is in the test program. The zip file was obtained from http://www.unicode.org/Public/cldr/22/core.zip. I don't know which program they used to create it, but I do know this error does not occur with most of their zip files, so I'm not sure how easy it would be to reproduce with a smaller set. |
This issue was closed by revision 7ec76e2. Status changed to Fixed. |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
by mpvanlohuizen:
Attachments:
The text was updated successfully, but these errors were encountered: